Look, Diana's friendship with J'onn in evidence! It's always so subtle, but it's there, people, and strong.
I never thought about it that way, but you're absolutely right. Only Kyle and Eel wouldn't have known about John Jones, so in essence he gave up nothing. Diana let him keep the rest of his secrets because she knows how important they are to him. Given how important truth is to her, and given that Bruce and Clark* finally let their guard down, it's telling that she let J'onn keep his up.
*-- Moreso Clark; Wally should have known Bruce but could plausibly not have known Clark.
I maintain they got badly cheated in FC: Requiem.
Yes they did. J'onn has usually gotten along best with those Leaguers who are also aliens in some fashion. Diana certainly qualifies; in many ways she's more of an alien that Clark ever could be.
Is it just me who finds it equally badass and hilarious the way Diana just saved Arthur?
Indeed. Total shout-out to the water weakness. Also, I will say this for the bathing suit costume: in the hands of a competent artist, it shows off Diana's muscles. Very few artists actually bother drawing women with actual muscle.
There: the one redeeming quality of the bathing suit.
She makes it easier for the rest of them to do what they have to, and she pulls her own weight as an individual.
In conclusion, Warlord. Multiclassed with Paladin when all is going well, but Warlord notwithstanding.
I'm happy that the Eel/John scene was kept. I think that it was the best moment in the arc, and one of the best in Waid's run period.
Finally: congratulations on the voice acting debut!